Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 구매자 선택 모달 버전업 Radio 적용 #134

Merged
merged 2 commits into from
Oct 18, 2023
Merged

feat: 구매자 선택 모달 버전업 Radio 적용 #134

merged 2 commits into from
Oct 18, 2023

Conversation

shinhyojeong
Copy link
Member

@shinhyojeong shinhyojeong commented Oct 14, 2023 •
edited
Loading

🔗 이슈 번호

⛳ 구현 사항

  • 구매자 선택 모달 버전업 Radio 적용

📚 구현 설명

  • Radio headless 적용
  • Radio Input 사이즈가 뭉개지는 이슈가 있어 ods에서 수정이 필요합니다 !

⏳ 실행 화면

스크린샷 2023-10-14 오후 9 18 46

@shinhyojeong shinhyojeong added feat 기능 추가, 삭제, 변경 Waiting Code Review labels Oct 14, 2023
@shinhyojeong shinhyojeong requested a review from a team October 14, 2023 12:19
@shinhyojeong shinhyojeong self-assigned this Oct 14, 2023
chojooyoung
chojooyoung approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@chojooyoung chojooyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LgTm~!

sonsurim
sonsurim approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@sonsurim sonsurim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 고생하셨십니당

@shinhyojeong shinhyojeong merged commit bfbf052 into develop Oct 18, 2023
@shinhyojeong shinhyojeong deleted the feat/#133_select-buyer-modal branch October 18, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonsurim sonsurim sonsurim approved these changes

@chojooyoung chojooyoung chojooyoung approved these changes

Assignees

@shinhyojeong shinhyojeong

Labels
feat 기능 추가, 삭제, 변경 In Progress Code Review
Projects
Offer FE
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: 구매자 선택 모달 버전업 Radio 적용
3 participants
@shinhyojeong @sonsurim @chojooyoung