Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output remote Node version #4337

Open
janpio opened this issue Dec 4, 2023 · 2 comments
Open

Output remote Node version #4337

janpio opened this issue Dec 4, 2023 · 2 comments
Labels
kind/tech A technical change. tech/typescript Issue for tech TypeScript.

Comments

@janpio
Copy link
Contributor

janpio commented Dec 4, 2023

Currently our setup outputs the local node version used to build and run a project.
But for Netlify and Co it does not output the remote version that is used to a) build the project and b) run the project (on Lambda).
Both of these are interesting and relevant as it could influence the experience a user has.

@janpio
Copy link
Contributor Author

janpio commented Dec 4, 2023

As simple as adding this to the returned body:

nodeVersion: process.versions.node,

@Jolg42 Jolg42 added tech/typescript Issue for tech TypeScript. kind/tech A technical change. labels Dec 6, 2023
@Jolg42
Copy link
Contributor

Jolg42 commented Dec 6, 2023

That would be nice indeed, but we will not be able to do an exact string matching anymore as this version could change anytime. (For example, when there is a Node.js patch)
Just adding this because it needs to be considered when outputting it in the current test setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/tech A technical change. tech/typescript Issue for tech TypeScript.
Projects
None yet
Development

No branches or pull requests

2 participants