refactor(mpz-circuits): binary type abstractions #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: mpz-common * reduce visibility of test module * pr feedback
* Adds an ideal ROT functionality to mpz-ot-core * Update ot/mpz-ot-core/src/ideal/ideal_rot.rs Derive Debug for IdealROT Co-authored-by: sinu.eth <[email protected]> * Add feedback * Add more feedback --------- Co-authored-by: sinu.eth <[email protected]>
* add transfer id * update co15 and kos15 * add Output type * feat(mpz-common): ideal functionality utils * refactor ideal functionalities and traits * pr feedback * impl ideal rot * Update crates/mpz-ot/src/ideal/rot.rs Co-authored-by: th4s <[email protected]> --------- Co-authored-by: th4s <[email protected]>
|
Hold off on reviewing this, I've run into limitations with the approach that have to be addressed |
sinui0
force-pushed
the
refactor/binary-type-abstractions
branch
from
7d8b2aa
to
2bd97ed
Compare
sinui0
force-pushed
the
threading-refactor
branch
2 times, most recently
from
197d9e8
to
e25d123
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an intermediate step towards making
mpz-circuitsgeneric over the field/elements it operates on.Both
mpz-memoryandmpz-binary-typeswill be integrated into our VM abstractions and should remove a considerable amount of duplication.Changes
mpz-binary-typesmpz-memory.mpz-circuitsto use these new crates.tracemacro inmpz-circuitsas we don't use it or intend to support it later.