Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

fix/update dependencies versions #1722

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Conversation

KimiWu123
Copy link
Contributor

@KimiWu123 KimiWu123 commented Jan 8, 2024

Description

Had following built error on my Mac (MacOS 12.6.7, M1 Pro)

error[E0658]: use of unstable library feature 'stdsimd'
   --> /Users/kimi/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ahash-0.8.7/src/operations.rs:124:24
    |
124 |     let res = unsafe { vaesmcq_u8(vaeseq_u8(transmute!(value), transmute!(0u128))) };
    |                        ^^^^^^^^^^
    |
    = note: see issue #48556 <https:/rust-lang/rust/issues/48556> for more information
    = help: add `#![feature(stdsimd)]` to the crate attributes to enable

...

Had following error if only to downgrade ahash to 0.8.6.

error[E0432]: unresolved import `revm_precompile`
 --> bus-mapping/src/precompile.rs:7:5
  |
7 | use revm_precompile::{Precompile, PrecompileError, Precompiles};
  |     ^^^^^^^^^^^^^^^ use of undeclared crate or module `revm_precompile`
  |

Fixed by upgrade revm_precompile to 2.2.0.

After upgrade revm_precompile to 2.2.0, CI complained library libclang.so missing. That's bcs revm_precompile 2.2.0 having c-kzg feature which needs libclang. So in this fix, we also disable default feature of revm-precompile (default-features=false).

Issue Link

N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Contents

Pinning a fixed version is a better practice so this PR is not only update the versions mentioned above but also using = to pin the version.

@github-actions github-actions bot added crate-bus-mapping Issues related to the bus-mapping workspace member crate-mock Issues related to the mock workspace member crate-integration-tests Issues related to the integration-tests workspace member crate-eth-types Issues related to the eth-types workspace member CI Issues related to the Continuous Integration mechanisms of the repository. labels Jan 8, 2024
@KimiWu123 KimiWu123 force-pushed the fix/update-dependecies-versions branch 9 times, most recently from b42cd0c to d0536e0 Compare January 9, 2024 08:33
@KimiWu123 KimiWu123 force-pushed the fix/update-dependecies-versions branch from d0536e0 to 3ed69e2 Compare January 9, 2024 08:53
@github-actions github-actions bot removed the CI Issues related to the Continuous Integration mechanisms of the repository. label Jan 9, 2024
Copy link
Collaborator

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix

@KimiWu123
Copy link
Contributor Author

Hi @adria0 , thanks for helping merge main branch. Wondering if you reviewed this PR already?

Copy link
Member

@adria0 adria0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adria0 adria0 added this pull request to the merge queue Jan 12, 2024
@adria0
Copy link
Member

adria0 commented Jan 12, 2024

Hi @adria0 , thanks for helping merge main branch. Wondering if you reviewed this PR already?

It took too much waiting the results of CI, and I forgot to check it again 😶‍🌫️

Merged via the queue into main with commit e80c5af Jan 12, 2024
13 checks passed
@adria0 adria0 deleted the fix/update-dependecies-versions branch January 12, 2024 08:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
crate-bus-mapping Issues related to the bus-mapping workspace member crate-eth-types Issues related to the eth-types workspace member crate-integration-tests Issues related to the integration-tests workspace member crate-mock Issues related to the mock workspace member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants