Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

upgrade geth to v1.10.18 to avoid using nightly #540

Merged
merged 9 commits into from
Jun 8, 2022
Merged

upgrade geth to v1.10.18 to avoid using nightly #540

merged 9 commits into from
Jun 8, 2022

Conversation

lispc
Copy link
Collaborator

@lispc lispc commented May 29, 2022

fixing #509

@lispc lispc requested a review from ed255 as a code owner May 29, 2022 08:33
@github-actions github-actions bot added crate-eth-types Issues related to the eth-types workspace member crate-geth-utils Issues related to the geth-utils workspace member crate-integration-tests Issues related to the integration-tests workspace member labels May 29, 2022
ed255
ed255 reviewed May 30, 2022
View reviewed changes
Copy link
Member

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at my comment about removing code that is no longer necessary. The rest looks good to me :)

eth-types/src/lib.rs Outdated Show resolved Hide resolved
ed255
ed255 approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ed255 ed255 requested review from a team and removed request for a team June 1, 2022 13:19
@ed255
Copy link
Member

ed255 commented Jun 1, 2022

@DreamWuGit could you do a review on this PR so that we achieve 2 approvals before merging?

DreamWuGit
DreamWuGit approved these changes Jun 7, 2022
View reviewed changes
Copy link
Collaborator

@DreamWuGit DreamWuGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the update!

@DreamWuGit
Copy link
Collaborator

Just be curious about how does geth-utils/go.sum generated ? should be by a tool ?

@ed255
Copy link
Member

ed255 commented Jun 7, 2022

Just be curious about how does geth-utils/go.sum generated ? should be by a tool ?

go.sum is automatically generated by the go tooling. For example when you run go test, go run or go build.
It's the equivalent of Cargo.lock in Rust.

@DreamWuGit
Copy link
Collaborator

go.sum is automatically generated by the go tooling. For example when you run go test, go run or go build.
It's the equivalent of Cargo.lock in Rust.

I see, thanks !!

@ed255 ed255 merged commit c9e0d42 into privacy-scaling-explorations:main Jun 8, 2022
@ed255 ed255 mentioned this pull request Jun 8, 2022
Closed
lispc referenced this pull request in scroll-tech/zkevm-circuits Jun 29, 2022
@lispc @DreamWuGit
upgrade geth to v1.10.18 to avoid using nightly (#540)
cc03828 
* upgrade geth to v1.10.18 to avoid using nightly

* clean

Co-authored-by: DreamWuGit <[email protected]>
lispc referenced this pull request in scroll-tech/zkevm-circuits Jun 30, 2022
@lispc @DreamWuGit
upgrade geth to v1.10.18 to avoid using nightly (#540)
96e7c88 
* upgrade geth to v1.10.18 to avoid using nightly

* clean

Co-authored-by: DreamWuGit <[email protected]>
lispc referenced this pull request in scroll-tech/zkevm-circuits Jul 4, 2022
@lispc
Revert "upgrade geth to v1.10.18 to avoid using nightly (#540)"
2197ce5 
This reverts commit c9e0d42.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DreamWuGit DreamWuGit DreamWuGit approved these changes

@ed255 ed255 ed255 approved these changes

Assignees
No one assigned
Labels
crate-eth-types Issues related to the eth-types workspace member crate-geth-utils Issues related to the geth-utils workspace member crate-integration-tests Issues related to the integration-tests workspace member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lispc @ed255 @DreamWuGit