Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Image link #1248

Closed
tushar5526 opened this issue Jul 26, 2022 · 3 comments
Closed

Broken Image link #1248

tushar5526 opened this issue Jul 26, 2022 · 3 comments

Comments

@tushar5526
Copy link

Most appropriate sections of the p5.js website?

Reference

What is your operating system?

Linux

Web browser and version

Google Chrome 103.0.5060.134 (Official Build) (64-bit)

Actual Behavior

The reference image for 4 * 4 matrix is broken here applyMatrix

Expected Behavior

It should not be broken

Steps to reproduce

Visit this applyMatrix

Would you like to work on the issue?

No

@Qianqianye
Copy link
Contributor

Qianqianye commented Jul 26, 2022

Thanks @tushar5526! It's currently fixed in this commit. The image is now back on the page.

But I noticed that the example code for applyMatrix is not showing, wondering if @Gaweph @limzykenneth could share some thoughts on this since you worked on this PR. We can also discuss the reference asset system between the p5.js website and p5.js repos. Thanks!

@limzykenneth
Copy link
Member

processing/p5.js#5738 Should fix the example problem.

For assets, it would be great to consolidate all website assets (all pages, examples, and reference) to one place, even if putting some in relevant subfolders such as a examples or reference folder is necessary. Reducing duplicates can also help with reducing the overall size of this repo and how long it takes to clone, I'm tempted to suggest symlinks in some cases but it probably won't play well with a variety of things so I'm not opening that can of worms yet.

@Qianqianye
Copy link
Contributor

Thanks @limzykenneth. The page https://p5js.org/reference/#/p5/applyMatrix is all fixed now in the recent 1.5.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants