Added p5.MediaElement.stop example #2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmccart
reviewed
Oct 3, 2017
lib/addons/p5.dom.js
Outdated
| * //above more readable. | ||
| * function setMessageAndBackground(message, backgroundColor) { | ||
| * background(backgroundColor); | ||
| * textAlign(CENTER); |
There was a problem hiding this comment.
couldn't these two lines get set in setup() then the text() line could replace the setMessageAndBackground() call in the mousClicked() function
There was a problem hiding this comment.
Hi @lmccart
I had the setMessageAndBackground() function in order to try simplify the repeated setting of the background and text. To be honest, I was worried about it (which is why it had that comment preamble about readability).
What I didn't consider was just not changing the background from light to dark gray. I've done that now and have pulled out the setMessageAndBackground() function.
I think it's better as an example now.
Thanks so much for the feedback!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #1954 - adds example for p5.MediaElement.stop.