Refactor vertex functions for composite paths #6606
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the progress so far, it has some flaws here and there, I will have to do some fixing/refactoring/renaming. (feel free to suggest some) |
lindapaiste
reviewed
Dec 11, 2023
Comment on lines
+10
to
+12
| get contourss() { | ||
| return this.contours; | ||
| } |
There was a problem hiding this comment.
A common naming convention is to use _ for the private/internal variables. So you would have this._contours and get contours() { return this._contours; }
If all that you are doing is returning the property as-is then you don't really need a getter. You can just use shape.contours directly. You can use JSDoc @readonly etc. to annotate the class.
lindapaiste
reviewed
Dec 11, 2023
| allVertObj.push(v); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
I think this is just a flatMap?
|
Thank you for the suggestions! I've taken note of all of them. Closing this PR as we're shifting towards a new approach! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #6560
This PR introduces the suggested way (as discussed in #6560 by @davepagurek and @GregStanton ) to refactor endShape to enable it for composite paths for 2D.
Changes:
Vertex,BezierVertex,QuadraticVertex,CurveVertex)endShapeby looping through the vertex objects.Shape,Contour,ContourSegmentto organize the construction and manipulation of the vertex objects.Screenshots of the change:
All the vertex objects works as expected!
PR Checklist
npm run lintpasses