Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @VERSION@ and @SEMVER@ in captcha_cmd option #3835

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

badlop
Copy link
Member

@badlop badlop commented Jun 2, 2022

Those macros are useful because the example captcha scripts are copied in a path ejabberd-$VERSION/priv/bin tha depends on the ejabberd version number, and changes for each release. Also, depending on the install method (one that uses rebar3, or Elixir's mix), that $VERSION may be in XX.YY or in SEMVER format (respectively).

Thanks to @weiss for the semver_to_xxyy/1 function code.

@coveralls
Copy link

coveralls commented Jun 2, 2022

Coverage Status

Coverage decreased (-0.005%) to 33.604% when pulling 217e930 on badlop:captchaversion into fbf43f2 on processone:master.

@badlop badlop changed the title Support @VERSION_XXYY@ and @VERSION_SEMVER@ in captcha_cmd option Support @VERSION@ and @SEMVER@ in captcha_cmd option Jun 3, 2022
@Neustradamus
Copy link
Contributor

@badlop: It will be in 22.10?

@badlop badlop merged commit 8ea7690 into processone:master Oct 24, 2022
@badlop badlop added this to the ejabberd 22.xx milestone Oct 24, 2022
@badlop
Copy link
Member Author

badlop commented Oct 24, 2022

@badlop: It will be in 22.10?

Finally, yes

@badlop badlop deleted the captchaversion branch January 10, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants