Make name in storage:bookmark conference optional

processone · Sep 27, 2023 · 68cb07d · 68cb07d
1 parent a4ddbbb
commit 68cb07d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/specs/xmpp_codec.spec b/specs/xmpp_codec.spec
@@ -348,8 +348,7 @@
  module = 'xep0048',
  result = {bookmark_conference, '$name', '$jid',
  '$autojoin', '$nick', '$password'},
- attrs = [#attr{name = <<"name">>,
- required = true},
+ attrs = [#attr{name = <<"name">>},
  #attr{name = <<"jid">>,
  required = true,
  dec = {jid, decode, []},

diff --git a/src/xep0048.erl b/src/xep0048.erl
@@ -404,15 +404,13 @@ encode_bookmark_conference({bookmark_conference,
 
 decode_bookmark_conference_attr_name(__TopXMLNS,
  undefined) ->
- erlang:error({xmpp_codec,
- {missing_attr,
- <<"name">>,
- <<"conference">>,
- __TopXMLNS}});
+ <<>>;
 decode_bookmark_conference_attr_name(__TopXMLNS,
  _val) ->
  _val.
 
+encode_bookmark_conference_attr_name(<<>>, _acc) ->
+ _acc;
 encode_bookmark_conference_attr_name(_val, _acc) ->
  [{<<"name">>, _val} | _acc].