removed copy method

profunktor · May 23, 2024 · ef2bcdc · ef2bcdc
1 parent b94b0b2
commit ef2bcdc
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 18 deletions.
diff --git a/modules/effects/src/main/scala/dev/profunktor/redis4cats/algebra/keys.scala b/modules/effects/src/main/scala/dev/profunktor/redis4cats/algebra/keys.scala
@@ -16,15 +16,13 @@
 
 package dev.profunktor.redis4cats.algebra
 
-import java.time.Instant
 import dev.profunktor.redis4cats.data.KeyScanCursor
-import dev.profunktor.redis4cats.effects.{ CopyArgs, ExpireExistenceArg, RestoreArgs, ScanArgs }
+import dev.profunktor.redis4cats.effects.{ ExpireExistenceArg, RestoreArgs, ScanArgs }
 
+import java.time.Instant
 import scala.concurrent.duration.FiniteDuration
 
 trait KeyCommands[F[_], K] {
- def copy(source: K, destination: K): F[Boolean]
- def copy(source: K, destination: K, copyArgs: CopyArgs): F[Boolean]
  def del(key: K*): F[Long]
  def dump(key: K): F[Option[Array[Byte]]]
  def exists(key: K*): F[Boolean]

diff --git a/modules/effects/src/main/scala/dev/profunktor/redis4cats/redis.scala b/modules/effects/src/main/scala/dev/profunktor/redis4cats/redis.scala
@@ -43,11 +43,11 @@ import io.lettuce.core.{
  ZAddArgs,
  ZAggregateArgs,
  ZStoreArgs,
+ CopyArgs => JCopyArgs,
  ExpireArgs => JExpireArgs,
  FlushMode => JFlushMode,
  FunctionRestoreMode => JFunctionRestoreMode,
  GetExArgs => JGetExArgs,
- CopyArgs => JCopyArgs,
  Limit => JLimit,
  Range => JRange,
  ReadFrom => JReadFrom,
@@ -470,12 +470,6 @@ private[redis4cats] class BaseRedis[F[_]: FutureLift: MonadThrow: Log, K, V](
  if (cluster) conn.clusterSync else conn.sync.widen
 
  /** ***************************** Keys API ************************************ */
- override def copy(source: K, destination: K): F[Boolean] =
- async.flatMap(_.copy(source, destination).futureLift.map(x => Boolean.box(x)))
-
- override def copy(source: K, destination: K, copyArgs: CopyArgs): F[Boolean] =
- async.flatMap(_.copy(source, destination, copyArgs.asJava).futureLift.map(x => Boolean.box(x)))
-
  def del(key: K*): F[Long] =
  async.flatMap(_.del(key: _*).futureLift.map(x => Long.box(x)))
 

diff --git a/modules/tests/src/test/scala/dev/profunktor/redis4cats/TestScenarios.scala b/modules/tests/src/test/scala/dev/profunktor/redis4cats/TestScenarios.scala
@@ -220,9 +220,9 @@ trait TestScenarios { self: FunSuite =>
  }
 
  def keysScenario(redis: RedisCommands[IO, String, String]): IO[Unit] = {
- val key1  = "key1"
- val key2  = "key2"
- val keyCopy = "keyCopy"
+ val key1 = "key1"
+ val key2 = "key2"
+
  for {
  x <- redis.get(key1)
  _ <- IO(assertEquals(x, None))
@@ -238,10 +238,6 @@ trait TestScenarios { self: FunSuite =>
  _ <- redis.restore(key1, dump.get, RestoreArgs().replace(true))
  restored <- redis.get(key1)
  _ <- IO(assertEquals(restored, Some("some value")))
- copy <- redis.copy(key1, keyCopy)
- _ <- IO(assertEquals(copy, true))
- _ <- redis.get(keyCopy).map(value => assert(value.contains("some value")))
- _ <- redis.del(keyCopy)
  idletime2 <- redis.objectIdletime(key1)
  _ <- IO(assert(idletime2.isDefined))
  _ <- redis.mSet(Map(key2 -> "some value 2"))