Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After thousands of log files have accumulated, opening the Historical page becomes slow. A lot of the wait time comes from the
list_log_files
function, which scans the log files and summarizes them. I profiled this function and found that nearly half of the execution time is spent indateutil.parser.parse
, which is used to parse the time from the beginning of the log filename. I presume theparse
function is slow because it must guess what time format has been used.I tried switching to
datetime.datetime.strptime
, and this gave a significant speedup, but still a decent amount of time was spent instrptime
, perhaps because it needs to parse the format string argument. Manually converting the pieces to integers and passing them directly intodatetime.datetime()
reduced the processing time to a negligible amount, and reduced the execution time oflist_log_files
by about 45%.