Upgrade to Tabulator 6.3.0 #921
Merged
+274
−288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's probably easiest to review the code changes while ignoring differences in white space: https:/projecthorus/radiosonde_auto_rx/pull/921/files?w=1 |
|
I'm tracking a flight now, and the telemetry table looks to be working as expected. |
|
I noticed that the source map for Tabulator (which I had added) was rather large, so I took it out to avoid bloating Auto-RX. If anyone needs it for debugging purposes, they can always download their own copy. |
|
I also noticed that I forgot to update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #915.
Updating Tabulator fixes the issue with the telemetry table (and map) displaying incorrectly in Firefox. I chose the latest available release, 6.3.0. A number of API changes have been made, so I updated the Auto-RX code where needed.
I've tested the Historical page, but haven't yet had a chance to verify that the telemetry table works correctly during a flight. (I'll have a chance in an hour or two.)