Added support for polymorphic relations. Fixes #487. #864
Conversation
| $bindings[$index + 1] = $columnReference['foreign']->getPhpName(); | ||
|
|
||
| if ($this->getForeignKey()->isPolymorphic()) { | ||
| throw new \InvalidArgumentException(sprintf('AggregateColumnBehavior does not work with polymorphic relations.')); |
There was a problem hiding this comment.
The sprintf call can be removed here
Added support for polymorphic relations. Fixes #487.
|
Thanks guys! |
|
|
||
| return isset($m[$local]) ? $m[$local] : null; | ||
| $index = array_search($local, $this->localColumns); | ||
| return $this->foreignColumns[$index]; |
There was a problem hiding this comment.
should this return null when $local could not be found using array_search instead of issue a php warnig because of a undefined index $this->foreignColumns[$index]?
same below in getMappedLocalColumn()
There was a problem hiding this comment.
No, if it can't be found, it's a internal error and should trigger warnings/errors. returning null would be wrong.
There was a problem hiding this comment.
but then we should throw a exception instead of implicitly rely on the warning? This is public api, so it should help the user to find the cause of errors
There was a problem hiding this comment.
Feel free. I don't think it's necessary as it's only used in internal code.
#487