Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when binding methods #331

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

BasConijn
Copy link
Contributor

@BasConijn BasConijn commented Jul 4, 2024

I am converting some WCF services to GRPC using this (awesome) package. However sometimes there are methods with overloads in the service class. This throws an "An item with the same key has already been added", though the message did not mention the name of the method it was trying to bind.

Copy link
Member

@mgravell mgravell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! For the record, can you confirm that you're able and willing to contribute this to the project in line with the project license?

@BasConijn
Copy link
Contributor Author

Yes, i am willing to contribute.

@mgravell mgravell merged commit b92259d into protobuf-net:main Jul 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants