Disallow empty value in list. #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_445142675
branch
from
3e7df3d
to
eb5c8c8
Compare
$ echo "x [a, , b]" | blaze-bin/third_party/txtpbfmt/fmt parser.Format for path <stdin> with content "x [a, , b]\n" returned err Empty value in list. F0428 14:10:56.453731 680717 fmt.go:103] 1 error(s) encountered during execution Note that this doesn't prevent empty strings: $ echo "x [a, '' , b]" | blaze-bin/third_party/txtpbfmt/fmt x [a, "", b] PiperOrigin-RevId: 445142675
copybara-service
bot
force-pushed
the
test_445142675
branch
from
eb5c8c8
to
fcaa1b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disallow empty value in list.
$ echo "x [a, , b]" | blaze-bin/third_party/txtpbfmt/fmt
parser.Format for path with content "x [a, , b]\n" returned err Empty value in list.
F0428 14:10:56.453731 680717 fmt.go:103] 1 error(s) encountered during execution
Note that this doesn't prevent empty strings:
$ echo "x [a, '' , b]" | blaze-bin/third_party/txtpbfmt/fmt
x [a, "", b]