Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lua binding compatibility for lua 5.3+ #13750

Closed
owent opened this issue Aug 12, 2022 · 2 comments · Fixed by #18800 · May be fixed by protocolbuffers/upb#735
Closed

Lua binding compatibility for lua 5.3+ #13750

owent opened this issue Aug 12, 2022 · 2 comments · Fixed by #18800 · May be fixed by protocolbuffers/upb#735
Labels
inactive Denotes the issue/PR has not seen activity in the last 90 days.

Comments

@owent
Copy link
Contributor

owent commented Aug 12, 2022 •
edited
Loading

  1. luaL_checkint is replaced by luaL_checkinteger and is removed from lua 5.3
  2. lua_isinteger is already defined in lua 5.3+
  3. else if (isprint(ch)) in upb/bindings/lua/upbc.cc is UB when ch is negative, and will crash when compiled by MSVC.
@owent owent mentioned this issue Aug 12, 2022
Open
@acozzette acozzette transferred this issue from protocolbuffers/upb Aug 29, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2024

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago.

@github-actions github-actions bot added the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Jan 7, 2024
@owent owent mentioned this issue Jan 7, 2024
Closed
@github-actions GitHub Actions
Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please reopen it.

This issue was closed and archived because there has been no new activity in the 14 days since the inactive label was added.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 22, 2024
copybara-service bot pushed a commit that referenced this issue Oct 11, 2024
@owent @copybara-github
Fix compiling problems with lua 5.4 (#15113)
3fbf6d5 
Fixes #15112
Fixes #13750

Closes #15113

COPYBARA_INTEGRATE_REVIEW=#15113 from owent:fixes_15112 dd3a847
FUTURE_COPYBARA_INTEGRATE_REVIEW=#15113 from owent:fixes_15112 dd3a847
PiperOrigin-RevId: 684918921
@copybara-service copybara-service bot mentioned this issue Oct 11, 2024
Merged
copybara-service bot pushed a commit that referenced this issue Oct 11, 2024
@owent @copybara-github
Fix compiling problems with lua 5.4 (#15113)
71f4971 
Fixes #15112
Fixes #13750

Closes #15113

COPYBARA_INTEGRATE_REVIEW=#15113 from owent:fixes_15112 dd3a847
FUTURE_COPYBARA_INTEGRATE_REVIEW=#15113 from owent:fixes_15112 dd3a847
PiperOrigin-RevId: 684918921
copybara-service bot pushed a commit that referenced this issue Oct 11, 2024
@owent @copybara-github
Fix compiling problems with lua 5.4 (#15113)
a673d33 
Fixes #15112
Fixes #13750

Closes #15113

COPYBARA_INTEGRATE_REVIEW=#15113 from owent:fixes_15112 dd3a847
PiperOrigin-RevId: 684928784
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
inactive Denotes the issue/PR has not seen activity in the last 90 days.
Projects
None yet
Milestone
No milestone
1 participant
@owent