HTTP endpoint for GetValidatorParticipation
#14261
Conversation
beacon-chain/rpc/core/validator.go
Outdated
| return nil, &RpcError{Reason: Internal, Err: errors.Wrap(err, "could not pre compute attestations: %v")} | ||
| } | ||
| } else { | ||
| return nil, &RpcError{Reason: Internal, Err: fmt.Errorf("invalid state type retrieved with a version of %d", beaconSt.Version())} |
There was a problem hiding this comment.
| return nil, &RpcError{Reason: Internal, Err: fmt.Errorf("invalid state type retrieved with a version of %d", beaconSt.Version())} | |
| return nil, &RpcError{Reason: Internal, Err: fmt.Errorf("invalid state type retrieved with a version of %s", version.String(beaconSt.Version()))} |
| Epoch string `json:"epoch"` | ||
| StateID bool `json:"state_id"` |
There was a problem hiding this comment.
Looks like you do not ever read the epoch parameter in the handler and rely on state_id instead. This makes sense to me but:
- we have to remove the
epochparam if we ignore it anyway; otherwise it will confuse callers - let's handle
state_idin the same way as in Beacon API handlers; this means using theStaterto fetch states, which allows us to pass the following into the param:
"head" (canonical head in node's view), "genesis", "finalized", "justified", , <hex encoded stateRoot with 0x prefix>
There was a problem hiding this comment.
We do use the epoch, I set it to prioritize the state_id if it's set but it isn't required so in the default case where state_id doesn't match anything we set the epoch which is technically required in this case so that else I have doesn't actually do anything and would need to be removed here, or just remove the required:
default:
_, e, ok := shared.UintFromQuery(w, r, "epoch", true)
if !ok {
currentSlot := s.CoreService.GenesisTimeFetcher.CurrentSlot()
currentEpoch := slots.ToEpoch(currentSlot)
epoch = uint64(currentEpoch)
} else {
epoch = e
}
}
There was a problem hiding this comment.
Ah OK, I missed it. I don't have that strong of an opinion on this, but having just a state_id and using the Stater similarly to how we do it in Beacon API makes things simpler and more uniform.
beacon-chain/rpc/endpoints.go
Outdated
| template: "/prysm/v1/validators/participation", | ||
| name: namespace + ".GetValidatorParticipation", | ||
| middleware: []mux.MiddlewareFunc{ | ||
| middleware.ContentTypeHandler([]string{api.JsonMediaType}), |
What type of PR is this?
Other
What does this PR do? Why is it needed?
Adding the HTTP endpoint for
GetValidatorParticipation.I had discussed with Preston about potentially adding more default epoch options, beyond just
genesis.I added a new query param called
state_idand added cases forhead,finalizedandgenesisWhich issues(s) does this PR fix?
N/A
Other notes for review