Do not directly dial a peer we cannot reach #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
approved these changes
Apr 13, 2019
terencechain
approved these changes
Apr 13, 2019
Codecov Report
@@ Coverage Diff @@
## master #2245 +/- ##
=========================================
- Coverage 69.11% 68.91% -0.2%
=========================================
Files 116 116
Lines 8881 8854 -27
=========================================
- Hits 6138 6102 -36
- Misses 2096 2099 +3
- Partials 647 653 +6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2233
The fallback is to request the information on broadcast. There seem to be scenarios where we cannot connect to a peer, or we are not actually peered with the person we want to dial. Instead, we will just broadcast for the information.