Merge pull request #337 from lptn/improve-testing-experience

Improve testing experience, do not override `composer check` command

.github/workflows/test.yml

@@ -41,7 +41,7 @@ jobs:
  run: composer install
 
  - name: Run Unit tests
- run: composer unit
+ run: composer test:unit
 
 
  acceptance_tests:
@@ -77,4 +77,4 @@ jobs:
  run: composer update --with='laravel/framework:${{ matrix.laravel }}' --no-interaction --no-progress --prefer-dist --prefer-stable
 
  - name: Run Acceptance Tests
- run: composer test
+ run: composer test:type

composer.json

@@ -66,22 +66,20 @@
  },
  "scripts": {
  "analyze": "psalm --find-dead-code --find-unused-psalm-suppress --long-progress",
- "cs": "@lint",
- "cs-fix": "@lint-fix",
- "check": [
- "@unit",
- "@analyze",
- "@lint",
- "@test"
- ],
  "lint": "phpcs --report-full --report-summary --colors -n -s",
  "lint-fix": "phpcbf -n",
  "psalm": "@analyze",
  "psalm-set-baseline": "@php ./psalm --set-baseline=psalm-baseline.xml",
  "test": [
+ "@lint",
+ "@psalm",
+ "@test:unit",
+ "@test:type"
+ ],
+ "test:type": [
  "Composer\\Config::disableProcessTimeout",
  "codecept run --skip-group skip"
  ],
- "unit": "phpunit"
+ "test:unit": "phpunit"
  }
 }

tests/Application/laravel-test.sh

@@ -10,7 +10,7 @@ rm -rf $APP_INSTALLATION_PATH
 
 echo "Installing Laravel"
 # See https:/laravel/laravel/tags for Laravel versions
-composer create-project laravel/laravel $APP_INSTALLATION_PATH 10.0 --quiet --prefer-dist
+composer create-project --quiet --prefer-dist laravel/laravel $APP_INSTALLATION_PATH 10.0 --quiet --prefer-dist
 cd $APP_INSTALLATION_PATH
 
 echo "Preparing Laravel"

tests/Application/lumen-test.sh

@@ -10,7 +10,7 @@ rm -rf $APP_INSTALLATION_PATH
 
 echo "Installing Lumen"
 # See https:/laravel/lumen/tags for Lumen versions
-composer create-project laravel/lumen $APP_INSTALLATION_PATH 10.0 --quiet --prefer-dist
+composer create-project --quiet --prefer-dist laravel/lumen $APP_INSTALLATION_PATH 10.0 --quiet --prefer-dist
 cd $APP_INSTALLATION_PATH
 
 echo "Adding package from source"

tests/README.md

@@ -1,6 +1,6 @@
 # Tests
 
 There are 3 types of tests:
-1. Acceptance (main one): Use Codeception to run Psalm over code snippets i a context of fake Laravel app [using orchestra/testbench]
+1. Acceptance (main one): Use Codeception to run Psalm over code snippets in a context of fake Laravel app [using orchestra/testbench]
 2. Application: create an [almost] empty Laravel (or Lumen) app and run Psalm over its codebase.
 3. Unit: use PHPUnit to test some internal logic without running Psalm.