Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for logger helper #161

Closed
mr-feek opened this issue Jun 29, 2021 · 0 comments
Closed

Support for logger helper #161

mr-feek opened this issue Jun 29, 2021 · 0 comments
Assignees
@mr-feek
Labels
enhancement New feature or request

Comments

@mr-feek
Copy link
Collaborator

mr-feek commented Jun 29, 2021

Is your feature request related to a problem? Please describe.
the logger helper should always return an instance of \Illuminate\Log\LogManager when one parameter is supplied.

ERROR: PossiblyNullReference - src/Middleware/RetryRateLimitErrors.php:50:19 - Cannot call method notice on possibly null value (see https://psalm.dev/083)
        logger()->notice('my message', [

Describe the solution you'd like
A stub should work fine
@mr-feek mr-feek added the enhancement New feature or request label Jun 29, 2021
@mr-feek mr-feek self-assigned this Jun 29, 2021
mr-feek added a commit that referenced this issue Jul 4, 2021
@mr-feek
feature: proper return types for logger. closes #161
6132f55
@mr-feek mr-feek closed this as completed in 72c74de Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mr-feek mr-feek

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mr-feek