Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure factory() helper is gone in Laravel 8+ #182

Merged
merged 4 commits into from
Jul 13, 2021
Merged

Ensure factory() helper is gone in Laravel 8+ #182

merged 4 commits into from
Jul 13, 2021

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Jul 9, 2021 •
edited
Loading

⚠️ Includes 🍒 from #181.

@caugner caugner changed the title test: that factory() helper is gone in Laravel 8+ Ensure that factory() helper is gone in Laravel 8+ Jul 9, 2021
@caugner caugner changed the title Ensure that factory() helper is gone in Laravel 8+ Ensure factory() helper is gone in Laravel 8+ Jul 9, 2021
@caugner caugner marked this pull request as ready for review July 13, 2021 08:08
@caugner
Copy link
Contributor Author

caugner commented Jul 13, 2021

@mr-feek This PR is ready to be merged now.

Afterwards I will rebase #157, because that PR also contains feature: support stubs per major version. This PR has a smaller scope, so I think it's better to add that feature here (#182).

@caugner caugner mentioned this pull request Jul 13, 2021
Merged
@mr-feek mr-feek added the enhancement New feature or request label Jul 13, 2021
@mr-feek
Copy link
Collaborator

mr-feek commented Jul 13, 2021

thanks!

@mr-feek mr-feek merged commit bb47983 into psalm:master Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caugner @mr-feek