Ensures that Collections are built using the LicenseBuilder and RenderingBuilder #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpendragon
reviewed
Oct 20, 2017
| # This is currently here to work around https:/iiif-prezi/osullivan/issues/56 | ||
| if identifier? | ||
| if manifest.is_a? FasterIIIFManifest | ||
| manifest.rendering = rendering_hash |
There was a problem hiding this comment.
Why not just do manifest["rendering"] = rendering_hash?
… the IIIF Manifest
…eBuilder and porting the RenderingBuilder
jrgriffiniii
force-pushed
the
issues-379-jrgriffiniii-sr-mvw-manifests
branch
from
ec8c48e
to
e1ef1e4
Compare
Removing the mutator method ManifestBuilder::FasterIIIFManifest#rendering=
jrgriffiniii
force-pushed
the
issues-379-jrgriffiniii-sr-mvw-manifests
branch
from
9b1c4d9
to
103724f
Compare
|
This has been updated and is prepared for another review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #379