perf: use single putenv call for exiftool

Signed-off-by: Varun Patil <[email protected]>
pulsejet · Oct 13, 2024 · 86707ed · 86707ed
1 parent 70d519d
commit 86707ed
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/lib/Exif.php b/lib/Exif.php
@@ -431,8 +431,6 @@ public static function getExifWithDuplicates(string $path): array
 
  private static function getExiftool(): array
  {
- putenv('LANG=C'); // set perl lang to suppress warning
-
  return BinExt::getExiftool();
  }
 

diff --git a/lib/Service/BinExt.php b/lib/Service/BinExt.php
@@ -12,6 +12,9 @@ class BinExt
  public const GOVOD_VER = '0.2.5';
  public const NX_VER_MIN = '1.1';
 
+ /** Exiftool environment is initialized in this process */
+ private static bool $hasExiftoolEnv = false;
+
  /** Get the path to the temp directory */
  public static function getTmpPath(): string
  {
@@ -117,6 +120,11 @@ public static function getExiftoolPBin(): string
  */
  public static function getExiftool(): array
  {
+ if (!self::$hasExiftoolEnv) {
+ self::$hasExiftoolEnv = true;
+ putenv('LANG=C'); // set perl lang to suppress warning
+ }
+
  if (SystemConfig::get('memories.exiftool_no_local')) {
  return ['perl', realpath(__DIR__.'/../../bin-ext/exiftool/exiftool')];
  }