update examples to use default providers #1641
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukehoban
reviewed
Jun 6, 2024
| ## EKS Cluster | ||
| with pulumi.default_providers([provider]): | ||
| ec2_role, eks_role = iam.setup_iam() | ||
| eks_security_group, subnet_ids = vpc.vpc() |
There was a problem hiding this comment.
This is sort of the interesting bit - and also where "global" approach would run into some problems - I assume the dependent modules would all be loaded and run before we could "install" the default provider?
That said - this does lead to a decent amount more code refactoring to get to something that works?
| @@ -1,72 +1,73 @@ | |||
| from pulumi_aws import config, iam | |||
| import json | |||
|
|
|||
| ## EKS Cluster Role | |||
| def setup_iam(): | |||
There was a problem hiding this comment.
This is sort of introducing another new kind of "nesting" - beyond:
- Components
- Python modules
I suspect in practice we would want to encourage refactoring into components in these cases?
| minSize: 1, | ||
| maxSize: 2, | ||
| let cluster: eks.Cluster | undefined; | ||
| pulumi.withDefaultProviders([provider, providerVersioned], () => { |
There was a problem hiding this comment.
What does this do? How does the code within here consume these two different AWS providers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for demonstration purposes only.