Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(secgroups): use standalone secgroup rules instead of in-line rules #108

Closed
wants to merge 3 commits into from
Closed

fix(secgroups): use standalone secgroup rules instead of in-line rules #108

wants to merge 3 commits into from

Conversation

metral
Copy link
Contributor

@metral metral commented Apr 23, 2019

fixes: #106
rel: #69

@metral
fix(secgroups): replace in-line rules with standalone secgroup rules
032047f 
- null out the secgroup ingress & egress to revoke any existing rules
- create new standalone secgroup rules
@metral
fix(secgroups): enable revokeRulesOnDelete for secgroups
e8e46ac
@metral metral changed the title feat(secgroups): use standalone secgroup rules instead of in-line rules fix(secgroups): use standalone secgroup rules instead of in-line rules Apr 23, 2019
@metral metral requested a review from lukehoban April 23, 2019 06:12
@metral metral closed this Apr 23, 2019
@metral metral removed the request for review from lukehoban May 4, 2019 17:25
@metral metral deleted the metral/use-sg-rules branch May 4, 2019 17:25
@metral
Copy link
Contributor Author

metral commented May 4, 2019

Replaced with #109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move from secgroup in-line rules to standalone secgroup rules
1 participant
@metral