apt::mark with setting => unhold is not idempotent

[aboks]

Describe the Bug

A resource declation like

apt::mark { 'foo':
  setting => unhold
}

is not idempotent and will execute on every Puppet run.

Expected Behavior

I would expect this resource to be idempotent, so that it can be used to ensure that a certain package is not held.

Steps to Reproduce

Add an apt::mark resource as above for an installed package that is not held, and observe Puppet executing it on every run.

Environment

• Version 8.2.0 (but seems to be still present in main)
• Platform Debian 11 & 12

Additional Context

It seems that the unless_cmd for unhold is just not configured:

puppetlabs-apt/manifests/mark.pp

Line 16 in 22ed8ab

$unless_cmd = undef

Something like ! (/usr/bin/apt-mark showhold ${title} | grep ${title} -q), or adding /usr/bin/apt-mark showhold ${title} | grep ${title} -q to onlyif, should probably work.