Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] Allow arbitrary IAM function in pvlib.iam.marion_diffuse #2050

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

[DRAFT] Allow arbitrary IAM function in pvlib.iam.marion_diffuse #2050

Show file tree
Hide file tree
Changes from 26 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
2a50a63
Add iam_pchip function and callable model for marion_diffuse
markcampanelli May 12, 2024
398a8ff
Tidy up
markcampanelli May 12, 2024
ed79db8
Appease flake8
markcampanelli May 12, 2024
d596e28
Pin flake8 to match github workflow
markcampanelli May 12, 2024
3e3f0d6
Tidy up more
markcampanelli May 12, 2024
f63a018
Improve test
markcampanelli May 12, 2024
bc519be
Only use pchip in tests
markcampanelli May 15, 2024
d97d077
flake8 ftw
markcampanelli May 15, 2024
c4c18d7
flake8 more ftw
markcampanelli May 15, 2024
8727b04
Remove unused lines in test
markcampanelli May 15, 2024
e726eed
Merge branch 'markcampanelli/main' into marion_diffuse_dep_inj
markcampanelli Jun 30, 2024
6322523
Update builtin models and models' parameters maps
markcampanelli Jun 30, 2024
fe7833b
Appease flake8
markcampanelli Jun 30, 2024
5d218d5
Appease flake8 more
markcampanelli Jun 30, 2024
bcc8429
Undo function moves
markcampanelli Jun 30, 2024
deb466e
Revert to better exception message
markcampanelli Jun 30, 2024
05319f3
Make iam_model required for ModelChain
markcampanelli Jul 1, 2024
dd8408f
Restore infer_aoi_model
markcampanelli Jul 1, 2024
1bd8f0d
Revert additional changes
markcampanelli Jul 1, 2024
0aff7c7
Address failing test and minimize diff
markcampanelli Jul 1, 2024
567374f
Get ModelChain codecov
markcampanelli Jul 1, 2024
e41621a
Add/improve test coverage
markcampanelli Jul 1, 2024
6a0d14d
Add docstring and cover bad model name
markcampanelli Jul 1, 2024
a580ec6
Appease flake8
markcampanelli Jul 1, 2024
2bb3fb6
Cover required params check
markcampanelli Jul 1, 2024
b6fe2bf
Minimize unrelated diff
markcampanelli Jul 1, 2024
2c0d11b
Test get_builtin_models
markcampanelli Jul 1, 2024
083c3c9
Improve comment
markcampanelli Jul 1, 2024
ce7577c
Remove spurious function
markcampanelli Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/flake8.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
with:
python-version: '3.11'
- name: Install Flake8 5.0.4 linter
run: pip install flake8==5.0.4 # use this version for --diff option
run: pip install flake8==5.0.4 # use this version for --diff option, should match version in pyproject.toml
- name: Setup Flake8 output matcher for PR annotations
run: echo '::add-matcher::.github/workflows/flake8-linter-matcher.json'
- name: Fetch pull request target branch
Expand Down
Loading
Loading