Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Implement Michalsky's solar position algorithm #2167

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kandersolar
Copy link
Member

It may be useful to compare this implementation with SOLPOS (easily available in python via SolarUtils). SOLPOS is at least partially related to Michalsky, although I'm not yet sure if their outputs should be expected to be identical.

TODO: check whether the code works in the southern hemisphere (I saw it mentioned that the "original form" of the equations does not).

@AdamRJensen
Copy link
Member

Note, the solar position used by SOLPOS is the same as the Michalsky solar position algorithm. However, SOLPOS uses a different refraction correction algorithm than that given in the Michalsky paper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants