Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for sdk-34 #5

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Update for sdk-34 #5

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0ba22f3
updated docker file
jgw96 Aug 8, 2024
fe78aa7
Merge pull request #4 from pwa-builder/sdk-34
jgw96 Aug 8, 2024
15ef672
update to version from Android dev site
jgw96 Aug 8, 2024
c52792c
Merge branch 'dev' of https:/pwa-builder/docker-android-b…
jgw96 Aug 8, 2024
5b1f0a0
Update Dockerfile
jgw96 Aug 8, 2024
a2ec5ce
update tagged sdk list + dont install jdk 8
jgw96 Aug 8, 2024
759da4e
Merge branch 'dev' of https:/pwa-builder/docker-android-b…
jgw96 Aug 8, 2024
6df1ffc
remove all refs to JDK 8
jgw96 Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
# when _TAGGED is "tagged" the version in _VERSION will be used.
# _TAGGED is used to handle the build stages

# "9123335" as of 2023/01/11
# "\6609375" as of 2024/08/08
jgw96 marked this conversation as resolved.
Show resolved Hide resolved
ARG ANDROID_SDK_TOOLS_TAGGED="latest"
ARG ANDROID_SDK_TOOLS_VERSION="9123335"
ARG ANDROID_SDK_TOOLS_VERSION="6609375"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious where you find this specific number? I thought it was the latest from developer android website, which is different right now
image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got this from here https:/GoogleChromeLabs/bubblewrap/blob/main/packages/cli/src/lib/AndroidSdkToolsInstaller.ts#L22, but yeah this is weird. Hmmm

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, the commit is 4 years old, if you see the current android-build-box it has a comment (that I think can be a great addition to this part... including a similar comment)

image

https:/mingchen/docker-android-build-box/blob/322550ee312b9daf3737fc8941975835c4b7c189/Dockerfile#L8

recent number is 11.xxx.xxx as well


# Valid values are "last8" or "tagged"
# "last8" will grab the last 8 android-sdks, including extensions and
Expand Down
Loading