Manage a stack of local graphic state #290

gmischler · 2021-10-31T23:34:33Z

as of #250 (second part).

New ability to change graphics state settings temporarily.
New context manager .local_context() to create a temporary state environment.
Rotations don't conflict with graphics state settings anymore.
Templates don't need to jump through hoops anymore to rotate stuff.

*Values of csv files are converted by position, instead of content * Updated tests to check for regression * Updated documentation and tests to include multiline text.

restrict decimal seperator replacement to float fields

… fields.

codecov · 2021-10-31T23:58:52Z

Codecov Report

Merging #290 (18bd976) into master (5a08e1b) will increase coverage by 0.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
+ Coverage   87.18%   87.41%   +0.23%     
==========================================
  Files          16       17       +1     
  Lines        3832     3871      +39     
  Branches      816      802      -14     
==========================================
+ Hits         3341     3384      +43     
+ Misses        318      314       -4     
  Partials      173      173

Impacted Files	Coverage Δ
fpdf/fpdf.py	`83.93% <100.00%> (-0.16%)`	⬇️
fpdf/graphics_state.py	`100.00% <100.00%> (ø)`
fpdf/template.py	`93.23% <100.00%> (+1.10%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a08e1b...18bd976. Read the comment docs.

Lucas-C

Good job overall @gmischler !

I made a few comments on your PR

CHANGELOG.md

fpdf/fpdf.py

fpdf/graphics_state.py

fpdf/fpdf.py

fpdf/graphics_state.py

test/template/test_flextemplate.py

Lucas-C · 2021-11-12T21:31:59Z

Thank you @gmischler for this great code refactoring!

Lucas-C · 2021-11-19T13:52:47Z

FYI I mentioned you in this blog article 😉
https://chezsoi.org/lucas/blog/hacktoberfest-on-fpdf2.html

gmischler added 30 commits September 18, 2021 16:33

Fix parsing of csv template files

71bd53d

*Values of csv files are converted by position, instead of content * Updated tests to check for regression * Updated documentation and tests to include multiline text.

fixes suggested by static code check

d70bc37

Update template.py

6ed9686

restrict decimal seperator replacement to float fields

now it's dark.

fa62a8d

do some hardcoded template tests without multiline

f1d7802

first round Splitting Template() into FlexTemplate()

ec69b8f

offset and rotate for render(), first test

6771592

small fixes and cleanup

536e819

removing mistaken checkin

42e0d27

test for multipage Template(); Template.code39 with standard template…

5b1d889

… fields.

refer defaults to type handlers, x2 optional for barcodes

92c9e28

more template and flextemplate tests

0195db4

Merge remote-tracking branch 'upstream/master'

bb97a63

static check fixes

e5ab09c

more pylint

fdb03de

blackity-black

56f639e

even blacker

bef03d1

Expand docstrings, update help, hide private methods.

cad0264

Issues from PR review

0f99984

Merge remote-tracking branch 'upstream/master'

1af4365

Issue #226 solved: Rotate anything anywhere

bba1ca1

Issue #238 solved - split_multicell doesn't modify target document

b89147a

Documentation details and corrections

13e9739

breaking up long line

058f7ea

rotation fix slightly changed barcode output

5807548

Update CHANGELOG.md

557148a

Include _write() in template rotation test

ddba2ce

FlexTemplate.render() with scaling

4847792

empty text field - consistency between T and W

6f2c98f

Enforce user input types as early as possible

2b2d82e

gmischler added 13 commits October 11, 2021 21:59

Merge remote-tracking branch 'upstream/master'

de230b8

bugfix: Keep track of nested rotation contexts

2582afb

test fix: text file loaded in binary mode

a6501f3

new set_dash_pattern(); dashed_line() retired

f26a873

Merge remote-tracking branch 'upstream/master'

325566c

test update for deprecated dashed_line()

bae8b76

mask unused argument in test

007e00b

error message fix, expand test coverage

a96bcc3

updates based on PR review

b04c879

Merge remote-tracking branch 'upstream/master'

41672c5

Graphics state stack implemented, rotation fixed

f5573ef

Simplify Templates again, making use of flexible rotation

fec5188

code cleanup

c201180

gmischler requested a review from Lucas-C as a code owner October 31, 2021 23:34

gmischler added 3 commits November 1, 2021 00:54

Merge remote-tracking branch 'upstream/master'

cdcdf37

merging updates from upstream

f4f2dd0

Update flextemplate_rotation.pdf

35df15b

gmischler added 2 commits November 2, 2021 22:09

Merge remote-tracking branch 'upstream/master'

6c46a5f

Updating changelog

5ebb144

Lucas-C requested changes Nov 9, 2021

View reviewed changes

gmischler added 5 commits November 10, 2021 19:33

Merge remote-tracking branch 'upstream/master'

e1299a2

include line_width in graphics context stack

604a6b0

hopefully fixing line endings

29c4266

changes discussed in PR review

516be96

migrating test_regular_polygon.py to standard fixture

18bd976

Lucas-C approved these changes Nov 12, 2021

View reviewed changes

Lucas-C merged commit 3b6a8d9 into py-pdf:master Nov 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Manage a stack of local graphic state #290

Manage a stack of local graphic state #290

gmischler commented Oct 31, 2021

codecov bot commented Oct 31, 2021 •

edited

Loading

Lucas-C left a comment

Lucas-C commented Nov 12, 2021

Lucas-C commented Nov 19, 2021

Manage a stack of local graphic state #290

Manage a stack of local graphic state #290

Conversation

gmischler commented Oct 31, 2021

codecov bot commented Oct 31, 2021 • edited Loading

Codecov Report

Lucas-C left a comment

Choose a reason for hiding this comment

Lucas-C commented Nov 12, 2021

Lucas-C commented Nov 19, 2021

codecov bot commented Oct 31, 2021 •

edited

Loading