Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Add merger test cases with real PDFs #1006

Merged
merged 4 commits into from
Jun 19, 2022
Merged

Conversation

MartinThoma
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 18, 2022

Codecov Report

Merging #1006 (b2dd5e6) into main (c540896) will increase coverage by 0.87%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1006      +/-   ##
==========================================
+ Coverage   89.76%   90.63%   +0.87%     
==========================================
  Files          18       18              
  Lines        4113     4113              
  Branches      870      870              
==========================================
+ Hits         3692     3728      +36     
+ Misses        263      236      -27     
+ Partials      158      149       -9     
Impacted Files Coverage Δ
PyPDF2/_writer.py 88.92% <0.00%> (+0.72%) ⬆️
PyPDF2/_reader.py 90.89% <0.00%> (+1.35%) ⬆️
PyPDF2/_merger.py 87.10% <0.00%> (+7.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c540896...b2dd5e6. Read the comment docs.

@MartinThoma MartinThoma marked this pull request as ready for review June 19, 2022 05:31
@MartinThoma MartinThoma merged commit c57e59b into main Jun 19, 2022
@MartinThoma MartinThoma deleted the tst-merger-with-pdfs branch June 19, 2022 05:36
MartinThoma added a commit that referenced this pull request Jun 19, 2022
The highlight of this release is improved support for file encryption
(AES-128 and AES-256, R5 only). See #749 for the amazing work of
@exiledkingcc 🎊 Thank you 🤗

Deprecations (DEP):
-  Rename names to be PEP8-compliant (#967)
  - `PdfWriter.get_page`: the pageNumber parameter is renamed to page_number
  - `PyPDF2.filters`:
    * For all classes, a parameter rename: decodeParms ➔ decode_parms
    * decodeStreamData ➔ decode_stream_data
  - `PyPDF2.xmp`:
    * XmpInformation.rdfRoot ➔ XmpInformation.rdf_root
    * XmpInformation.xmp_createDate ➔ XmpInformation.xmp_create_date
    * XmpInformation.xmp_creatorTool ➔ XmpInformation.xmp_creator_tool
    * XmpInformation.xmp_metadataDate ➔ XmpInformation.xmp_metadata_date
    * XmpInformation.xmp_modifyDate ➔ XmpInformation.xmp_modify_date
    * XmpInformation.xmpMetadata ➔ XmpInformation.xmp_metadata
    * XmpInformation.xmpmm_documentId ➔ XmpInformation.xmpmm_document_id
    * XmpInformation.xmpmm_instanceId ➔ XmpInformation.xmpmm_instance_id
  - `PyPDF2.generic`:
    * readHexStringFromStream ➔ read_hex_string_from_stream
    * initializeFromDictionary ➔ initialize_from_dictionary
    * createStringObject ➔ create_string_object
    * TreeObject.hasChildren ➔ TreeObject.has_children
    * TreeObject.emptyTree ➔ TreeObject.empty_tree

New Features (ENH):
-  Add decrypt support for V5 and AES-128, AES-256 (R5 only) (#749)

Robustness (ROB):
-  Fix corrupted (wrongly) linear PDF (#1008)

Maintenance (MAINT):
-  Move PDF_Samples folder into ressources
-  Fix typos (#1007)

Testing (TST):
-  Improve encryption/decryption test (#1009)
-  Add merger test cases with real PDFs (#1006)
-  Add mutmut config

Code Style (STY):
-  Put pure data mappings in separate files (#1005)
-  Make encryption module private, apply pre-commit (#1010)

Full Changelog: 2.2.1...2.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant