Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROB: Fix 2 cases of "object has no attribute 'indirect_reference'" #1616

Merged
merged 2 commits into from
Feb 11, 2023

Conversation

pubpub-zz
Copy link
Collaborator

fixes #1614

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 91.91% // Head: 91.91% // No change to project coverage 👍

Coverage data is based on head (ce4da2a) compared to base (1b54821).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1616   +/-   ##
=======================================
  Coverage   91.91%   91.91%           
=======================================
  Files          33       33           
  Lines        6372     6372           
  Branches     1271     1271           
=======================================
  Hits         5857     5857           
  Misses        327      327           
  Partials      188      188           
Impacted Files Coverage Δ
pypdf/_writer.py 84.54% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pubpub-zz pubpub-zz changed the title ROB: fix annot directly stored in /Annots ROB: fix 2 cases of "object has no attribute 'indirect_reference'" Feb 9, 2023
@MartinThoma MartinThoma changed the title ROB: fix 2 cases of "object has no attribute 'indirect_reference'" ROB: Fix 2 cases of "object has no attribute 'indirect_reference'" Feb 11, 2023
@MartinThoma MartinThoma merged commit 7a807d2 into py-pdf:main Feb 11, 2023
MartinThoma added a commit that referenced this pull request Feb 12, 2023
Bug Fixes (BUG):
-  Switch from trimbox to cropbox when merging pages (#1622)
-  Text extraction not working with one glyph to char sequence (#1620)

Robustness (ROB):
-  Fix 2 cases of "object has no attribute \'indirect_reference\'" (#1616)

Testing (TST):
-  Add multiple retry on get_url for external PDF downloads (#1626)

[Full Changelog](3.4.0...3.4.1)
@pubpub-zz pubpub-zz deleted the iss1614 branch June 24, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'DictionaryObject' object has no attribute 'indirect_reference'
2 participants