-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add PdfWriter.remove_objects_from_page(page: PageObject, to_delete: ObjectDeletionFlag) #1648
Merged
Merged
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
d27adda
ROB : Remove Text not working in all cases
pubpub-zz 56e8b52
wipe text within XObjects
pubpub-zz 52a6329
mypy
pubpub-zz 3e2211b
fix remove_image
pubpub-zz aa22eda
pytest
pubpub-zz 9d0d566
ROB + TST
pubpub-zz 3649581
mypy
pubpub-zz f4b663c
rename func
pubpub-zz c42fa31
Merge remote-tracking branch 'py-pdf/main' into remove_text
pubpub-zz 0928c8d
Merge remote-tracking branch 'py-pdf/main' into remove_text
pubpub-zz 23b9146
Merge remote-tracking branch 'py-pdf/main' into remove_text
pubpub-zz 3ed6653
Revert "Merge remote-tracking branch 'py-pdf/main' into remove_text"
pubpub-zz 222c785
extensions in accordance with comments
pubpub-zz fe7fa62
fix
pubpub-zz c96c327
add test
pubpub-zz 0b388b8
mypy
pubpub-zz 10be747
fix loop
pubpub-zz 49aae98
Merge remote-tracking branch 'py-pdf/main' into remove_text
pubpub-zz d30ba30
pytest
pubpub-zz 2835c90
attempt
pubpub-zz b7095be
attempt 2
pubpub-zz 4721c9b
Merge branch 'main' into remove_text
pubpub-zz a89cbca
Update pypdf/_writer.py
pubpub-zz 3f47026
Update pypdf/_writer.py
pubpub-zz e8c2081
Update pypdf/_writer.py
pubpub-zz f0a357a
Update pypdf/_writer.py
pubpub-zz 1414cc5
Update pypdf/_writer.py
pubpub-zz 1ef07f8
Update pypdf/_writer.py
pubpub-zz 393838f
Update pypdf/_writer.py
pubpub-zz 663897e
Update pypdf/_writer.py
pubpub-zz 4459f46
Update pypdf/_writer.py
pubpub-zz 8129713
Update pypdf/_writer.py
pubpub-zz ab2e506
fix enum calls
pubpub-zz 48899c7
pytest
pubpub-zz b70986a
mypy
pubpub-zz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should make our lives here easier and not allow the Iterables (tuple / list). It is a flag and thus people should use it.
If they don't know it, they will just do multiple calls (which is fine as well)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see how to change keeping the code just affecting annotations/comments...