Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fix misuse of the word 'operand' in the docs #1684

Merged
merged 1 commit into from
Mar 5, 2023

Conversation

joshuagerstein
Copy link
Contributor

visitor_operand_before, visitor_operand_after are called on (operator, operands, cm_matrix, tm_matrix) in _page.py. However, the documentation said the first argument is 'operand.'

@codecov
Copy link

codecov bot commented Mar 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f20b363) 92.37% compared to head (5ea4ceb) 92.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1684   +/-   ##
=======================================
  Coverage   92.37%   92.37%           
=======================================
  Files          33       33           
  Lines        6481     6481           
  Branches     1281     1281           
=======================================
  Hits         5987     5987           
  Misses        320      320           
  Partials      174      174           
Impacted Files Coverage Δ
pypdf/_page.py 90.77% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MartinThoma MartinThoma merged commit 0f93983 into py-pdf:main Mar 5, 2023
@MartinThoma MartinThoma changed the title DOC: Fix misusage of the word 'operand' in documentation. DOC: Fix misuse of the word 'operand' in the docs Mar 5, 2023
@MartinThoma MartinThoma added the nf-documentation Non-functional change: Documentation label Mar 5, 2023
@MartinThoma
Copy link
Member

Thank you!

If you want, I can add you to the contributors: https://pypdf.readthedocs.io/en/latest/meta/CONTRIBUTORS.html :-)

@joshuagerstein
Copy link
Contributor Author

Gerstein, Joshua
This profile. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nf-documentation Non-functional change: Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants