Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Pass logging parameters correctly in set_need_appearances_writer #1697

Merged
merged 1 commit into from
Mar 11, 2023

Conversation

rolisz
Copy link
Contributor

@rolisz rolisz commented Mar 9, 2023

Without this, the logging module logs another error: TypeError: not all arguments converted during string formatting

Without this, the logging module logs another error: TypeError: not all arguments converted during string formatting
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8b0f091) 92.37% compared to head (2e9a00f) 92.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1697   +/-   ##
=======================================
  Coverage   92.37%   92.37%           
=======================================
  Files          33       33           
  Lines        6480     6480           
  Branches     1281     1281           
=======================================
  Hits         5986     5986           
  Misses        320      320           
  Partials      174      174           
Impacted Files Coverage Δ
pypdf/_writer.py 85.76% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pubpub-zz
Copy link
Collaborator

@rolisz, you seem to have met this issue with a file. Can you extend the tests in order to improve coverage?

@MartinThoma MartinThoma changed the title Pass logging parameters correctly BUG: Pass logging parameters correctly in set_need_appearances_writer Mar 11, 2023
@MartinThoma MartinThoma merged commit 7f1a3f8 into py-pdf:main Mar 11, 2023
@MartinThoma
Copy link
Member

MartinThoma commented Mar 11, 2023

Thank you for your contribution @rolisz ❤️ It will be part of the release tomorrow (pypdf > 3.5.1)

If you want I can add you as a contributor : https://pypdf.readthedocs.io/en/latest/meta/CONTRIBUTORS.html

@MartinThoma
Copy link
Member

I agree with @pubpub-zz : Adding a test case for this would be good. If you want to do that, please create another PR :-)

MartinThoma added a commit that referenced this pull request Mar 12, 2023
Bug Fixes (BUG)
-  compress_content_stream not readable in Adobe Acrobat (#1698)
-  Pass logging parameters correctly in set_need_appearances_writer (#1697)
-  Write /Root/AcroForm in set_need_appearances_writer (#1639)

Robustness (ROB)
-  Allow more whitespaces within linearized file (#1701)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants