Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Explicitly provide Any for IO generic argument #2272

Merged
merged 1 commit into from
Oct 28, 2023

Conversation

nilehmann
Copy link
Contributor

I'm using pypdf in a project configured with pyright and the reportUnknownMemberType option enabled. Since IO is not annotated explicitly with Any the error is triggered when using the append method of PdfWriter. This should probably also be fixed in pyright, but I thought the change here would be less controversial.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9047079) 94.44% compared to head (a48ce5a) 94.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2272   +/-   ##
=======================================
  Coverage   94.44%   94.44%           
=======================================
  Files          43       43           
  Lines        7634     7634           
  Branches     1506     1506           
=======================================
  Hits         7210     7210           
  Misses        262      262           
  Partials      162      162           
Files Coverage Δ
pypdf/_utils.py 98.58% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MartinThoma MartinThoma changed the title Explicitly provide Any for IO generic argument MAINT: Explicitly provide Any for IO generic argument Oct 28, 2023
@MartinThoma MartinThoma merged commit e587157 into py-pdf:main Oct 28, 2023
13 checks passed
@MartinThoma
Copy link
Member

Thank you 🤗

If you want, I can add you to https://pypdf.readthedocs.io/en/latest/meta/CONTRIBUTORS.html :-)

MartinThoma added a commit that referenced this pull request Oct 29, 2023
## What's new

### Security (SEC)
-  Infinite recursion when using PdfWriter(clone_from=reader) (#2264) by @Alexhuszagh

### New Features (ENH)
-  Add parameter to select images to be removed (#2214) by @pubpub-zz

### Bug Fixes (BUG)
-  Correctly handle image mode 1 with FlateDecode (#2249) by @stefan6419846
-  Error when filling a value with parentheses #2268 (#2269) by @KanorUbu
-  Handle empty root outline (#2239) by @pubpub-zz

### Documentation (DOC)
-  Improve merging docs (#2247) by @stefan6419846

### Developer Experience (DEV)
-  Test Python 3.7 with cryptopgraphy provider as well (#2276) by @stefan6419846
-  Run CI with windows-latest (#2258) by @MartinThoma
-  Use pytest-xdist (#2254) by @MartinThoma
-  Attribute correct authors in the release notes (#2246) by @stefan6419846

### Maintenance (MAINT)
-  Apply pre-commit hooks (#2277) by @MartinThoma
-  Update requirements + mypy fixes (#2275) by @MartinThoma
-  Explicitly provide Any for IO generic argument (#2272) by @nilehmann

### Testing (TST)
-  Fix test_image_without_pillow in windows environment (#2257) by @pubpub-zz

### Code Style (STY)
-  Remove unused import by @MartinThoma

[Full Changelog](3.16.4...3.17.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants