Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_iss1723 #2441

Closed
wants to merge 1 commit into from
Closed

Fix test_iss1723 #2441

wants to merge 1 commit into from

Conversation

sbourlon
Copy link
Contributor

@sbourlon sbourlon commented Feb 5, 2024

The test test_iss1723 is broken because it is getting the exception IndexError: sequence index out of range because index = -999.

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3fb63f7) 94.43% compared to head (6fc8419) 94.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2441   +/-   ##
=======================================
  Coverage   94.43%   94.43%           
=======================================
  Files          49       49           
  Lines        8008     8008           
  Branches     1616     1616           
=======================================
  Hits         7562     7562           
  Misses        276      276           
  Partials      170      170           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbourlon sbourlon changed the title For debugging only: for debugging github ci on Windows WIP: Fix test_iss1723 Feb 5, 2024
@stefan6419846
Copy link
Collaborator

By the way: You can test this on your own fork as well without having to submit a corresponding PR, see the change and screenshots in #2145.

@sbourlon
Copy link
Contributor Author

sbourlon commented Feb 6, 2024

Oh, thank you for the tips!

@sbourlon
Copy link
Contributor Author

sbourlon commented Feb 7, 2024

Should be fixed with PR #2440

@sbourlon sbourlon closed this Feb 7, 2024
@sbourlon sbourlon changed the title WIP: Fix test_iss1723 Fix test_iss1723 Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants