Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: add _get_page_number_from_indirect in writer #2493

Merged
merged 4 commits into from
Mar 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions pypdf/_writer.py
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,28 @@ def _get_num_pages(self) -> int:
pages = cast(Dict[str, Any], self.get_object(self._pages))
return int(pages[NameObject("/Count")])

def _get_page_number_by_indirect(
self, indirect_reference: Union[None, int, NullObject, IndirectObject]
) -> Optional[int]:
"""
Generate _page_id2num.

Args:
indirect_reference:

Returns:
The page number or None
"""
# to provide same function as in PdfReader
if indirect_reference is None or isinstance(indirect_reference, NullObject):
return None
if isinstance(indirect_reference, int):
indirect_reference = IndirectObject(indirect_reference, 0, self)
obj = indirect_reference.get_object()
if isinstance(obj, PageObject):
return obj.page_number
return None

@property
def pages(self) -> List[PageObject]:
"""
Expand Down
13 changes: 13 additions & 0 deletions tests/test_writer.py
Original file line number Diff line number Diff line change
Expand Up @@ -2011,3 +2011,16 @@ def test_reattach_fields():
assert isinstance(writer.pages[0]["/Annots"][0], IndirectObject)
del writer.pages[1]["/Annots"]
assert len(writer.reattach_fields(writer.pages[1])) == 0


def test_get_pagenumber_from_indirectobject():
"""Test test_get_pagenumber_from_indirectobject"""
pdf_path = RESOURCE_ROOT / "crazyones.pdf"
writer = PdfWriter(clone_from=pdf_path)
assert writer._get_page_number_by_indirect(None) is None
assert writer._get_page_number_by_indirect(NullObject()) is None

ind = writer.pages[0].indirect_reference
assert writer._get_page_number_by_indirect(ind) == 0
assert writer._get_page_number_by_indirect(ind.idnum) == 0
assert writer._get_page_number_by_indirect(ind.idnum + 1) is None
Loading