ROB: Allow non-strict mode in more objects #794
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinThoma
added
the
is-robustness-issue
MartinThoma
commented
Apr 22, 2022
Comment on lines
+407
to
+411
| msg = r"Unexpected escaped string: %s" % tok | ||
| if strict: | ||
| raise PdfReadError(msg) | ||
| else: | ||
| logger.warning(msg) |
There was a problem hiding this comment.
This is the key part of the mentioned issue
Codecov Report
@@ Coverage Diff @@
## main #794 +/- ##
==========================================
- Coverage 75.24% 75.17% -0.07%
==========================================
Files 11 11
Lines 3522 3525 +3
Branches 814 815 +1
==========================================
Hits 2650 2650
- Misses 658 661 +3
Partials 214 214
Continue to review full report at Codecov.
|
MartinThoma
added a commit
that referenced
this pull request
Apr 28, 2022
MartinThoma
added a commit
that referenced
this pull request
Apr 28, 2022
VictorCarlquist
pushed a commit
to VictorCarlquist/PyPDF2
that referenced
this pull request
Apr 29, 2022
An unexpected escape string was raising a PdfReadError before. Now, only a warning is issued. Closes py-pdf#360 Closes py-pdf#794 : Passing the strict parameter looks like a good idea, but there is also the pdf parameter. Sadly, it is None for that issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #360