BUG: XmpInformation._converter_date was unusable #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It gave
TypeError: 'staticmethod' object is not callable
Fix: Move it out of XmpInformation and use the function instead
of the static method
MartinThoma
force-pushed
the
issue-914-unbound-static
branch
from
538e9e8
to
98b284c
Compare
Codecov Report
@@ Coverage Diff @@
## 1.x #921 +/- ##
==========================================
+ Coverage 76.51% 77.25% +0.74%
==========================================
Files 17 17
Lines 4394 4393 -1
Branches 820 820
==========================================
+ Hits 3362 3394 +32
+ Misses 857 818 -39
- Partials 175 181 +6
Continue to review full report at Codecov.
|
MartinThoma
added a commit
that referenced
this pull request
May 29, 2022
Bug Fixes (BUG): - XmpInformation._converter_date was unusable (#921) Full Changelog: 1.28.3...1.28.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It gave
TypeError: 'staticmethod' object is not callable
Fix: Move it out of XmpInformation and use the function instead
of the static method
Closes #914