Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: test on macos big sur #5647

Closed
wants to merge 1 commit into from
Closed

feat: test on macos big sur #5647

wants to merge 1 commit into from

Conversation

jeremad
Copy link

@jeremad jeremad commented Dec 15, 2020

Add jobs to test on MacOS Big Sur

@@ -55,14 +55,17 @@ jobs:
path: cryptography-wheelhouse/

macos:
runs-on: macos-latest
runs-on: ${{ matrix.os }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need to do change our wheel builder, the wheels we build already work with any macOS version 10.10 and greater.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should probably have opened an issue first, but the prebuilt-wheel does not work on mac 11, it tries to re-compile

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying upgrading to a newer pip. It sounds like you're hitting pypa/pip#9138

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, I'll remove the duplicated release job then!

@jeremad jeremad changed the title feat: test and release on macos big sur feat: test on macos big sur Dec 15, 2020
@reaperhulk
Copy link
Member

I appreciate the fact that this PR is well-structured (really!), but we won't merge this for somewhat counterintuitive reasons.

  1. The concern you had (wheel not working with later macOS release) is not testable by our current CI since that requires packaging the wheel with our wheel builders and then downloading it onto a later OS release. This is doable, but complex for a case that has never caused an actual bug for us. In an ideal world we'd add that job anyway, but 7 years of constantly rebuilding our CI in new form has convinced me that we need to justify complexity given the very real costs (in both time and even more importantly reliability).
  2. We used to test on multiple macOS releases, but our dependency on specific versions of macOS is effectively nothing at this point (we have a single code path that depends on version, which we do test but is not used in any binaries produced by our wheel builder). Since macOS concurrency is low (5 jobs max) and we've never had a bug related to macOS versioning the decision was made to test only on latest. With GHA this currently means Catalina but we're comfortable with it switching to Big Sur whenever they swap it.

All the previous being said, clearly our CI will expand when arm64 macOS becomes available to us since that different arch (and the need to build wheels against it!) is sufficiently different to warrant CI resourcing.

@reaperhulk reaperhulk closed this Dec 15, 2020
@jeremad
Copy link
Author

jeremad commented Dec 16, 2020

OK! I understand, thank you anyway!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants