Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/test_unit.py: replace hardcoded "python3" executable name #107

Conversation

johanneskastl
Copy link
Contributor

do not use python3, rather use sys.executable to use the same python version this test is running with

…se the same python version this test is running with
@ssbarnea ssbarnea added the bug Something isn't working label May 6, 2023
@johanneskastl
Copy link
Contributor Author

Should I rebase, or will this interfere with the CI?

@ssbarnea
Copy link
Member

ssbarnea commented May 8, 2023

Rebace works fine with GHA, in fact is always a good idea to rebase.

@johanneskastl
Copy link
Contributor Author

Hooray, everything green! Can this be merged?

@johanneskastl
Copy link
Contributor Author

Can someone merge this? Before I have to rebase again :-)

@ssbarnea ssbarnea merged commit aeb3a13 into pycontribs:main Jun 1, 2023
@ssbarnea ssbarnea added skip-changelog Can be missed from the changelog. and removed bug Something isn't working labels Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Can be missed from the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants