Use more descriptive link texts #7625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
headtr1ck
approved these changes
Mar 15, 2023
doc/contributing.rst
Outdated
| @@ -732,8 +732,8 @@ or, to use a specific Python interpreter,:: | |||
| This will display stderr from the benchmarks, and use your local | |||
| ``python`` that comes from your ``$PATH``. | |||
|
|
|||
| Information on how to write a benchmark and how to use asv can be found in the | |||
| `asv documentation <https://asv.readthedocs.io/en/latest/writing_benchmarks.html>`_. | |||
| Learn `how to write a benchmark and how to use asv from the documentayion <https://asv.readthedocs.io/en/latest/writing_benchmarks.html>`_ . | |||
doc/user-guide/dask.rst
Outdated
| @@ -549,7 +549,7 @@ larger chunksizes. | |||
|
|
|||
| .. tip:: | |||
|
|
|||
| Check out the dask documentation on `chunks <https://docs.dask.org/en/latest/array-chunks.html>`_. | |||
| Check out the `dask documentation of chunks <https://docs.dask.org/en/latest/array-chunks.html>`_. | |||
There was a problem hiding this comment.
Not a native speaker but "on" sounds better to me?
|
Could you also merge main again? |
|
Thanks @remigathoni This is a great first contribution. Welcome to Xarray! We're excited to see your next contribution :) |
Thank you @dcherian ! |
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Mar 26, 2023
* main: (40 commits) Faq pull request (According to pull request pydata#7604 & issue pydata#1285 (pydata#7638) add timeouts for tests (pydata#7657) Pull Request Labeler - Undo workaround sync-labels bug (pydata#7667) [pre-commit.ci] pre-commit autoupdate (pydata#7651) Allow all integer dtypes in `polyval` (pydata#7619) [skip-ci] dev whats-new (pydata#7660) Redo whats-new for 2023.03.0 (pydata#7659) Set copy=False when calling pd.Series (pydata#7642) Pin pandas < 2 (pydata#7650) Whats-new for release 2023.03.0 (pydata#7643) Bump pypa/gh-action-pypi-publish from 1.7.1 to 1.8.1 (pydata#7648) Use more descriptive link texts (pydata#7625) Fix missing 'dim' argument in _get_nan_block_lengths (pydata#7598) Fix `pcolormesh` with str coords (pydata#7612) [skip-ci] Fix groupby binary ops benchmarks (pydata#7603) Remove incomplete sentence in IO docs (pydata#7631) Allow indexing unindexed dimensions using dask arrays (pydata#5873) Bump pypa/gh-action-pypi-publish from 1.6.4 to 1.7.1 (pydata#7618) [pre-commit.ci] pre-commit autoupdate (pydata#7620) add a test for scatter colorbar extend (pydata#7616) ...
dcherian
added a commit
to kmsquire/xarray
that referenced
this pull request
Mar 29, 2023
* upstream/main: (716 commits) Faq pull request (According to pull request pydata#7604 & issue pydata#1285 (pydata#7638) add timeouts for tests (pydata#7657) Pull Request Labeler - Undo workaround sync-labels bug (pydata#7667) [pre-commit.ci] pre-commit autoupdate (pydata#7651) Allow all integer dtypes in `polyval` (pydata#7619) [skip-ci] dev whats-new (pydata#7660) Redo whats-new for 2023.03.0 (pydata#7659) Set copy=False when calling pd.Series (pydata#7642) Pin pandas < 2 (pydata#7650) Whats-new for release 2023.03.0 (pydata#7643) Bump pypa/gh-action-pypi-publish from 1.7.1 to 1.8.1 (pydata#7648) Use more descriptive link texts (pydata#7625) Fix missing 'dim' argument in _get_nan_block_lengths (pydata#7598) Fix `pcolormesh` with str coords (pydata#7612) [skip-ci] Fix groupby binary ops benchmarks (pydata#7603) Remove incomplete sentence in IO docs (pydata#7631) Allow indexing unindexed dimensions using dask arrays (pydata#5873) Bump pypa/gh-action-pypi-publish from 1.6.4 to 1.7.1 (pydata#7618) [pre-commit.ci] pre-commit autoupdate (pydata#7620) add a test for scatter colorbar extend (pydata#7616) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @TomNicholas! This closes issue #7617, please review. Thanks!