Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused constants #2141

Merged
merged 5 commits into from
Apr 23, 2023
Merged

Remove unused constants #2141

merged 5 commits into from
Apr 23, 2023

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Apr 23, 2023

Description

Remove PY38_PLUS and previously deprecated BUILTINS constants.
Also remove Load, Store, and Del constants as those have already been aliases for Context enum.

@cdce8p cdce8p modified the milestones: 2.16.0, 3.0 Apr 23, 2023
astroid/bases.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #2141 (952868b) into main (7fa8481) will increase coverage by 0.25%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2141      +/-   ##
==========================================
+ Coverage   92.23%   92.48%   +0.25%     
==========================================
  Files          94       94              
  Lines       10889    10837      -52     
==========================================
- Hits        10043    10023      -20     
+ Misses        846      814      -32     
Flag Coverage Δ
linux 92.24% <100.00%> (+0.25%) ⬆️
pypy 87.51% <100.00%> (+0.23%) ⬆️
windows 92.08% <100.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
astroid/const.py 100.00% <ø> (ø)
astroid/__init__.py 100.00% <100.00%> (ø)
astroid/bases.py 88.04% <100.00%> (-0.07%) ⬇️
astroid/brain/brain_ssl.py 100.00% <100.00%> (ø)
astroid/brain/brain_typing.py 86.01% <100.00%> (-0.10%) ⬇️
astroid/brain/brain_unittest.py 100.00% <100.00%> (ø)
astroid/nodes/scoped_nodes/scoped_nodes.py 92.15% <100.00%> (ø)
astroid/rebuilder.py 96.60% <100.00%> (+5.37%) ⬆️

@cdce8p cdce8p merged commit 1336ee4 into pylint-dev:main Apr 23, 2023
@cdce8p cdce8p deleted the remove-py38_plus branch April 23, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants