Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated doc attribute #2154

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Remove deprecated doc attribute #2154

merged 1 commit into from
Apr 25, 2023

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Apr 25, 2023

Description

Remove the deprecated doc attribute in favor of just doc_node.
Refs #1868
Refs #2148

@cdce8p cdce8p added this to the 3.0.0a2 milestone Apr 25, 2023
@cdce8p cdce8p changed the title Remove deprecated doc attribute Remove deprecated doc attribute Apr 25, 2023
@cdce8p cdce8p mentioned this pull request Apr 25, 2023
10 tasks
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #2154 (7633f9c) into main (08ed413) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 7633f9c differs from pull request most recent head 564bbc6. Consider uploading reports for the commit 564bbc6 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2154      +/-   ##
==========================================
- Coverage   92.57%   92.55%   -0.03%     
==========================================
  Files          94       94              
  Lines       10819    10796      -23     
==========================================
- Hits        10016     9992      -24     
- Misses        803      804       +1     
Flag Coverage Δ
linux 92.31% <100.00%> (-0.03%) ⬇️
pypy 87.50% <100.00%> (-0.01%) ⬇️
windows 92.14% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
astroid/nodes/scoped_nodes/scoped_nodes.py 91.93% <100.00%> (-0.23%) ⬇️

... and 2 files with indirect coverage changes

DanielNoord
DanielNoord previously approved these changes Apr 25, 2023
@DanielNoord DanielNoord dismissed stale reviews from Pierre-Sassoulas and themself via 7633f9c April 25, 2023 17:01
DanielNoord
DanielNoord previously approved these changes Apr 25, 2023
@DanielNoord DanielNoord enabled auto-merge (squash) April 25, 2023 17:01
@cdce8p cdce8p disabled auto-merge April 25, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants