Use the inference cache when no context is provided #2257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, without an explicit InferenceContext instance, no checks were done against the global inference cache, and no entries were stored in it.
jacobtylerwalls
added
topic-performance
pylint-tested
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2257 +/- ##
==========================================
- Coverage 92.80% 92.78% -0.03%
==========================================
Files 94 94
Lines 10941 10937 -4
==========================================
- Hits 10154 10148 -6
- Misses 787 789 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jacobtylerwalls
commented
Jul 19, 2023
| * Use the global inference cache when inferring, even without an explicit | ||
| ``InferenceContext``. This is a significant performance improvement given how | ||
| often methods default to ``None`` for the context argument. (Linting ``astroid`` | ||
| itself now takes ~5% less time on Python 3.12; other projects requiring more |
There was a problem hiding this comment.
I saw a 14% improvement with music21. We can do an alpha and eyeball the pylint primer numbers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Previously, without an explicit
InferenceContextinstance, no checks were done against the global inference cache, and no entries were stored in it. This is a problem given how often the defaultcontext=Noneis used.Refs #529. The third point of #529 muses about some sort of global inference cache, which was added later in cf6528c. This current PR just finishes the job. I'll leave remarks on #529 about the remaining possible improvements.
There will be one change needed in pylint where the checker depends on retroengineering a particular inference path being traveled twice, but I've already got a patch for it.