Fix nonlocal in try block regression for used-before-assignment
#5966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, I'm wondering where we put the changelog when we backport vs when we don't backport. Probably a discussion for #5728 |
|
Probably should go in |
Pierre-Sassoulas
added
Needs backport
DanielNoord
approved these changes
Mar 25, 2022
|
Right. I need something to copy paste for the release so the Changelog for 2.13.1 is here for that, and the whatsnew for 2.13 is where everything is together for user. It does not help with the duplication problem later, but it's working. |
Pierre-Sassoulas
approved these changes
Mar 25, 2022
Pull Request Test Coverage Report for Build 2037611516
💛 - Coveralls |
Pierre-Sassoulas
removed
the
Needs backport
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Mar 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Fixes regression in 2.13 where names in
tryblocks were checked for the first time forused-before-assignment, but we needed to allow fornonlocals.Closes #5965
Question: does this need a changelog in what's new/2.13? Or is this part of the plan to reduce redundancy in the changelogs?