Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - manylinux2014 policy tests #193

Merged
merged 1 commit into from
Nov 10, 2019
Merged

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Sep 25, 2019

Add tests on top of #192
pip built from https:/mayeut/pip/tree/manylinux2014
docker image is automatically built from branch used for pypa/manylinux#348

@mayeut mayeut mentioned this pull request Sep 25, 2019
@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #193 into master will decrease coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
- Coverage   87.52%   87.32%   -0.21%     
==========================================
  Files          19       19              
  Lines         978      978              
  Branches      215      215              
==========================================
- Hits          856      854       -2     
- Misses         84       86       +2     
  Partials       38       38
Impacted Files Coverage Δ
auditwheel/main_repair.py 72.09% <0%> (-6.98%) ⬇️
auditwheel/policy/__init__.py 93.33% <0%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f350064...71ef333. Read the comment docs.

@mayeut mayeut force-pushed the manylinux2014-tests branch 2 times, most recently from 82f295a to f97c353 Compare October 2, 2019 21:34
@lkollar
Copy link
Contributor

lkollar commented Oct 4, 2019

So it seems this has to blockers: the new manylinux2014 image and an updated pip which supports the new tag. I assume you plan to wait for these before going ahead with the PR?

@mayeut
Copy link
Member Author

mayeut commented Oct 4, 2019

I assume you plan to wait for these before going ahead with the PR?

Yes. It's to show PR is almost ready and that manylinux2014 policy undergoes the same tests as other policies.
Since we're in a chicken and egg situation, I chose to do it this way rather than polluting the master branch with a 1MB custom pip wheel.

@mayeut mayeut force-pushed the manylinux2014-tests branch 6 times, most recently from dd4836f to 332cf39 Compare October 13, 2019 18:34
@mayeut
Copy link
Member Author

mayeut commented Oct 13, 2019

Tests are now built on top of #202

@mayeut mayeut force-pushed the manylinux2014-tests branch 2 times, most recently from 3b55d32 to 4363708 Compare October 19, 2019 10:23
@mayeut mayeut force-pushed the manylinux2014-tests branch 2 times, most recently from 48b288a to 71035a7 Compare November 7, 2019 22:16
@mayeut mayeut merged commit d9ffa80 into pypa:master Nov 10, 2019
@mayeut mayeut deleted the manylinux2014-tests branch November 10, 2019 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants