Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support --no-isolation with build[uv] #1889

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

henryiii
Copy link
Contributor

Fixing #1887. I didn't special case chained short flags, like -xn or -nx, maybe we should?

@joerick
Copy link
Contributor

joerick commented Jun 20, 2024

It looks to me like you're just disabling uv support when --no-isolation is passed. Is this a misconfiguration then? As in "you can't specify build[uv] and --no-isolation, if you need --no-isolation you must use build"?

@henryiii
Copy link
Contributor Author

We still install everything via uv when build[uv] is set. It means “use build and uv”. The problem is that with no isolation, build itself isn’t using uv because it doesn’t install anything or make and environment. That’s why it errors on that flag.

@joerick
Copy link
Contributor

joerick commented Jun 22, 2024

Ah, got it. Understood!

@henryiii henryiii marked this pull request as ready for review July 1, 2024 03:06
@henryiii
Copy link
Contributor Author

henryiii commented Jul 1, 2024

If I add a utility for this, it will clash with #1873, so let's do this as a quick fix, and then write a utility later that tries to be smarter for combined flags.

@henryiii
Copy link
Contributor Author

henryiii commented Jul 1, 2024

I think we could release after this. Would like to get b3 out!

@mayeut
Copy link
Member

mayeut commented Jul 1, 2024

I didn't special case chained short flags, like -xn or -nx, maybe we should?

I don't think it's necessary but a note / caution shall be added in the docs then.

Signed-off-by: Henry Schreiner <[email protected]>
@mayeut
Copy link
Member

mayeut commented Jul 1, 2024

I think we could release after this. Would like to get b3 out!

I cancelled Travis CI to get some time for manylinux. CentOS 7 reached End-Of-Life so mirrors shall be updated on manylinux2014. IMHO, we should wait for the new images before the release.

@henryiii henryiii merged commit 973946b into pypa:main Jul 2, 2024
22 of 23 checks passed
@henryiii henryiii deleted the henryiii/fix/uvnoiso branch July 2, 2024 00:15
MusicalNinjaDad pushed a commit to MusicalNinjaDad/cibuildwheel that referenced this pull request Jul 3, 2024
* fix: support --no-isolation with build[uv]

Signed-off-by: Henry Schreiner <[email protected]>

* docs: mention caveat

Signed-off-by: Henry Schreiner <[email protected]>

---------

Signed-off-by: Henry Schreiner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants